Menu

#1521 Filter Regex pattern not working

closed-fixed
nobody
5
2008-07-30
2007-07-06
TCB
No

When attempting to filter out the comment blocks on these test files, it also filtered out a line that it shouldn't have. It indicates that the files are identical.

I have attached the test files and jpeg files that show the details.

Discussion

  • TCB

    TCB - 2007-07-06

    Zip file w/2 src files for test and jpg images

     
  • TCB

    TCB - 2007-07-06

    Logged In: YES
    user_id=1837878
    Originator: YES

    Version is 2.6.8.0

     
  • Kimmo Varis

    Kimmo Varis - 2008-07-30
    • status: open --> closed-fixed
     
  • Kimmo Varis

    Kimmo Varis - 2008-07-30

    Logged In: YES
    user_id=631874
    Originator: NO

    Sorry it took so long to respond.

    Bug was in regexp implementation of diffutils. WinMerge 2.8.* uses PCRE regexps which fixed lots of bugs like this.

    However, your regexps don't work in 2.8.* either. Current implementation requires that regexp matches all lines in the difference, so you must match both | and - in the same regexp. Filtering comments is a bit tricky. :(

    I'll close this bug as fixed, since the regular expression matching works. I'll work with line filtering improvements and allow matching single lines etc.

     

Log in to post a comment.