Menu

#1728 Fails to detect a change

Trunk
closed-fixed
nobody
5
2010-01-15
2008-06-17
No

I'm attempting to diff two outputs of Wireshark. There's one byte in the packet dump that isn't being recognized as a changed byte. In the attached files, the byte 0x36 is "c0" in the original file, and "00" in the other file, but Winmerge isn't showing it as a change (it does mark the following three bytes).

(It appears I can only attach one file at a time)

Discussion

  • Andre Kostur

    Andre Kostur - 2008-06-17

    Source File

     
  • Andre Kostur

    Andre Kostur - 2008-06-17

    Logged In: YES
    user_id=243172
    Originator: YES

    Attaching the second file. And this is against v2.8.0.0 Unicode.
    File Added: wiresharkrenew.txt

     
  • Andre Kostur

    Andre Kostur - 2008-06-17

    Target File

     
  • Andre Kostur

    Andre Kostur - 2008-06-17

    Logged In: YES
    user_id=243172
    Originator: YES

    Looking closer, it's confused around that area.

    Byte 0x34 is marked as changed in the target file but not the source file, 0x36 isn't marked as changed in either file, 0x37 - 0x39 is marked as changed in the target file but not the source file, and 0x3a - 0x0x3d is marked as changed in the source but not the target file. The correct behaviour would be that bytes 0x36 - 0x39 should be marked in both files.

     
  • Marcel Gosselin

    Marcel Gosselin - 2008-07-17

    Logged In: YES
    user_id=1236935
    Originator: NO

    I can confirm that the bug still exist with most recent build (from source r5627).

    0030 *2d d0* 00 00 *80* 00 00 *00 00 00* c0 a8 48 c2 00 00 *-........*...H...
    0030 *56 91* 00 00 00 00 c0 a8 48 c2 *c0 a8 48 c2* 00 00 *V.......H*...H...

    Above is the problematic line with stars (*) surrounding what WinMerge's line diff engine has highlighted. Problem seems to be related to the repetitive nature of the line, lot of 00 and dots and the following sequence repeated twice: c0 a8 48 c2.

    Kimmo, this is probably the same bug as
    https://sourceforge.net/tracker/index.php?func=detail&aid=1910870&group_id=13216&atid=113216

     
  • Kimmo Varis

    Kimmo Varis - 2010-01-15
    • milestone: --> Trunk
    • status: open --> closed-fixed
     
  • Kimmo Varis

    Kimmo Varis - 2010-01-15

    This seems to be fixed in latest experimental release at least.

     

Log in to post a comment.