Menu ▾ ▴

#491 (Minor) code cleanup for SaveToFile

closed-accepted
None
5
2004-01-17
2004-01-14
No

cvs trunk

MergeDoc.cpp

Simplify error return from
CMergeDoc::CDiffTextBuffer::SaveToFile. Just return
error, instead of wrapping remainder of function in if
statement (which used to be required for cleanup code,
which is no longer present).

Discussion

  • Anonymous

    Anonymous - 2004-01-14

    Altered and original file (MergeDoc.cpp) 39Kb

     
    wm876556_cleanup_save_to_file.zip

  • Kimmo Varis

    Kimmo Varis - 2004-01-15

    Logged In: YES
    user_id=631874

    Looks good. I like how much simpler error handling in that
    code is now.

     

  • Kimmo Varis

    Kimmo Varis - 2004-01-17
    • status: open --> open-accepted
     

  • Kimmo Varis

    Kimmo Varis - 2004-01-17
    • assigned_to: nobody --> puddle
     

  • Kimmo Varis

    Kimmo Varis - 2004-01-17

    Logged In: YES
    user_id=631874

    I applied this patch:

    Checking in MergeDoc.cpp;
    /cvsroot/winmerge/WinMerge/Src/MergeDoc.cpp,v <-- MergeDoc.cpp
    new revision: 1.167; previous revision: 1.166
    done

     

  • Anonymous

    Anonymous - 2004-01-17

    Logged In: YES
    user_id=60964

    Thank you!
    Closing.

     

  • Anonymous

    Anonymous - 2004-01-17
    • status: open-accepted --> closed-accepted
     

Log in to post a comment.